Add children to the props for @types/react@18#192
Add children to the props for @types/react@18#192ChromeQ wants to merge 2 commits intomicrosoft:masterfrom ChromeQ:master
Conversation
|
Any update here? No way to switch to React 18 without this fix |
|
Can we get this merged? |
|
I am unfortunately not an admin on this project anymore, so I am unable to bypass a broken CI check |
|
Any update on this ? it would be nice if could merge this PR. |
|
Can this get merged and released? Waiting on this fix. |
|
Any updates on when this will be merged? |
|
Any updates? This is blocking any ability to upgrade to react 18 |
|
why was this deleted? |
|
I was cleaning up my personal repos and didn't realise it was linked to an open PR. The PR changes are still visible so you can create your own fork if you were relying on it. |
|
can you share how you moved away from it? |
I meant that I don't maintain the project which used this, in my new project I don't use Redux at all and use react context and providers instead. You can also use patch-package to apply these changes in your local node_modules rather than fork or maintain a package |
|
seems we can get away by just doing this: under |
In relation to React props should not do anything special with
childrenand DefinitelyTyped have updated the react types to v18DefinitelyTyped/DefinitelyTyped#59802